exp: save: Handle staged changes.

Staged changes were causing a merge error.
Warn and unstage instead of erroring, to match exp run behavior.
This commit is contained in:
David de la Iglesia Castro
2022-11-28 15:49:34 +01:00
parent 43e281521e
commit 665185b9e7
2 changed files with 20 additions and 2 deletions
+9 -1
View File
@@ -1,6 +1,6 @@
import logging
import os
from typing import TYPE_CHECKING, Optional
from typing import TYPE_CHECKING, List, Optional
from funcy import first
@@ -23,6 +23,14 @@ def save(
queue = repo.experiments.workspace_queue
logger.debug("Saving workspace in %s", os.getcwd())
staged, _, _ = repo.scm.status(untracked_files="no")
if staged:
logger.warning(
"Your workspace contains staged Git changes which will be "
"unstaged before saving this experiment."
)
repo.scm.reset()
entry = repo.experiments.new(queue=queue, name=name, force=force)
executor = queue.init_executor(repo.experiments, entry)
save_result = executor.save(executor.info, force=force)
+11 -1
View File
@@ -49,7 +49,7 @@ def test_exp_save_overwrite_experiment(tmp_dir, dvc, scm, exp_stage):
dvc.experiments.save(name="dummy", force=True)
def test_exp_save_multiple(tmp_dir, dvc, scm, exp_stage):
def test_exp_save_multiple(tmp_dir, dvc, scm):
baseline = scm.get_rev()
for i in range(2):
name = f"exp-{i}"
@@ -76,3 +76,13 @@ def test_exp_save_after_commit(tmp_dir, dvc, scm, exp_stage):
all_exps = dvc.experiments.ls(all_commits=True)
assert all_exps[baseline] == ["exp-1"]
assert all_exps[new_baseline] == ["exp-2"]
def test_exp_save_with_staged_changes(tmp_dir, dvc, scm):
tmp_dir.gen({"new_file": "new_file"})
scm.add("new_file")
dvc.experiments.save(name="exp")
_, _, unstaged = scm.status()
assert "new_file" in unstaged