bench: check for dvc_bin.version instead of dvc_rev (#10764)

* bench: check for dvc_bin.version instead of dvc_rev

* Update dvc/testing/benchmarks/cli/stories/use_cases/test_sharing.py

* Update dvc/testing/benchmarks/cli/stories/use_cases/test_sharing.py
This commit is contained in:
skshetry
2025-06-05 11:41:04 +05:45
committed by GitHub
parent 18177a6579
commit 5fb8986dbd
2 changed files with 6 additions and 3 deletions
@@ -3,10 +3,12 @@ import shutil
from packaging import version from packaging import version
def test_sharing(bench_dvc, tmp_dir, dvc, make_dataset, remote, dvc_rev): def test_sharing(bench_dvc, tmp_dir, dvc, make_dataset, remote, dvc_bin):
is_gs = dvc.config["remote"]["upstream"]["url"].startswith("gs://") is_gs = dvc.config["remote"]["upstream"]["url"].startswith("gs://")
if dvc_rev and is_gs and version.Version(dvc_rev) < version.Version("3.59.3"): if is_gs and version.Version(dvc_bin.version) < version.Version("3.59.2"):
# support for allow_anonymous_login in gs was introduced in dvc==3.59.3 # support for allow_anonymous_login in gs was introduced in dvc==3.60
# This should not impact the test, just that it will make it slower if used
# with fake-gcs-server.
with dvc.config.edit() as d: with dvc.config.edit() as d:
d["remote"]["upstream"].pop("allow_anonymous_login", None) d["remote"]["upstream"].pop("allow_anonymous_login", None)
+1
View File
@@ -173,6 +173,7 @@ filterwarnings = [
"ignore:nx.nx_pydot.* depends on the pydot package, which has.*known issues and is not actively maintained:DeprecationWarning", "ignore:nx.nx_pydot.* depends on the pydot package, which has.*known issues and is not actively maintained:DeprecationWarning",
# TODO: investigate where we are not closing sqlite3.Connection # TODO: investigate where we are not closing sqlite3.Connection
"ignore:unclosed database.*sqlite3.Connection:ResourceWarning", "ignore:unclosed database.*sqlite3.Connection:ResourceWarning",
"ignore:unclosed.*<socket.socket:ResourceWarning",
] ]
log_level = "debug" log_level = "debug"
markers = [ markers = [