From 5b8bf52eabd5aad884cb06891177f91bddcb9ace Mon Sep 17 00:00:00 2001
From: David de la Iglesia Castro <daviddelaiglesiacastro@gmail.com>
Date: Tue, 11 Jan 2022 13:01:29 +0100
Subject: [PATCH] plots: Fix `--json` requiring `-o`.

`-o` was being required even when renderers don't need output path.
---
 dvc/command/plots.py             |  2 +-
 tests/unit/command/test_plots.py | 45 ++++++++++++++++++++++++++++++++
 2 files changed, 46 insertions(+), 1 deletion(-)

diff --git a/dvc/command/plots.py b/dvc/command/plots.py
index f0676e3eb..95172ec98 100644
--- a/dvc/command/plots.py
+++ b/dvc/command/plots.py
@@ -14,7 +14,7 @@ logger = logging.getLogger(__name__)
 
 
 def _show_json(renderers, path: None):
-    if any(lambda r: r.needs_output_path for r in renderers) and not path:
+    if any(r.needs_output_path for r in renderers) and not path:
         raise DvcException("Output path ('-o') is required!")
 
     result = {
diff --git a/tests/unit/command/test_plots.py b/tests/unit/command/test_plots.py
index 62ef36bf0..c5d81b193 100644
--- a/tests/unit/command/test_plots.py
+++ b/tests/unit/command/test_plots.py
@@ -297,3 +297,48 @@ def test_plots_diff_json(dvc, mocker, capsys):
     show_json_mock.assert_called_once_with(renderers, "out")
 
     render_mock.assert_not_called()
+
+
+def test_show_json_requires_out(dvc, mocker, capsys):
+    cli_args = parse_args(
+        [
+            "plots",
+            "diff",
+            "HEAD~10",
+            "HEAD~1",
+            "--json",
+            "--targets",
+            "plot.csv",
+        ]
+    )
+    cmd = cli_args.func(cli_args)
+
+    mocker.patch("dvc.repo.plots.diff.diff")
+
+    renderer = mocker.MagicMock()
+    renderer.needs_output_path = False
+    renderer.filename = "foo"
+    renderer.as_json.return_value = "{}"
+    mocker.patch("dvc.render.utils.match_renderers", return_value=[renderer])
+
+    assert cmd.run() == 0
+
+    renderer.needs_output_path = True
+
+    assert cmd.run() == 1
+
+    cli_args = parse_args(
+        [
+            "plots",
+            "diff",
+            "HEAD~10",
+            "HEAD~1",
+            "--json",
+            "--targets",
+            "plot.csv",
+            "-o",
+            "out",
+        ]
+    )
+    cmd = cli_args.func(cli_args)
+    assert cmd.run() == 0