From 566d7b48d033a3379c86e5611f4a48aa19c074f4 Mon Sep 17 00:00:00 2001 From: Ruslan Kuprieiev Date: Fri, 18 Oct 2019 12:32:22 +0300 Subject: [PATCH] lock: monkeypatch socket.getfqdn used by flufl.lock (#2628) Workaround for slow and obsoleted gethostbyaddr used in `socket.getfqdn()`. See [1], [2] and [3] for more info. [1] https://bugs.python.org/issue5004 [2] https://github.com/iterative/dvc/issues/2582 [3] https://gitlab.com/warsaw/flufl.lock/merge_requests/12 Flufl.lock guys seem unresponsive, so we have to monkeypatch this by ourselves, at least for now. Fixes #2582 --- dvc/lock.py | 31 +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+) diff --git a/dvc/lock.py b/dvc/lock.py index 3ab223adf..eebd8db2e 100644 --- a/dvc/lock.py +++ b/dvc/lock.py @@ -22,7 +22,38 @@ class LockError(DvcException): if is_py3: + import socket + import flufl.lock + from funcy import monkey + + # Workaround for slow and obsoleted gethostbyaddr used in + # `socket.getfqdn()`. See [1], [2] and [3] for more info. + # + # [1] https://bugs.python.org/issue5004 + # [2] https://github.com/iterative/dvc/issues/2582 + # [3] https://gitlab.com/warsaw/flufl.lock/merge_requests/12 + @monkey(socket) + def getfqdn(name=""): + """Get fully qualified domain name from name. + + An empty argument is interpreted as meaning the local host. + """ + name = name.strip() + if not name or name == "0.0.0.0": + name = socket.gethostname() + try: + addrs = socket.getaddrinfo( + name, None, 0, socket.SOCK_DGRAM, 0, socket.AI_CANONNAME + ) + except socket.error: + pass + else: + for addr in addrs: + if addr[3]: + name = addr[3] + break + return name class Lock(flufl.lock.Lock): """Class for dvc repo lock.