Stone_Red/dvc
1
0
Fork 0
mirror of https://github.com/Stone-Red-Code/dvc.git synced 2026-11-02 07:18:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

api: Fix params_show when stage has no params

Browse Source 
Also fix when `deps=True` and no params in the entire pipeline.

Closes #8064
This commit is contained in:
David de la Iglesia Castro
2022-08-05 16:26:19 +03:00
committed by Ruslan Kuprieiev
parent c7b22b467c
commit 45ac64ddde
2 changed files with 28 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/func/api/test_params.py
+23
View File
@@ -12,6 +12,11 @@ def params_repo(tmp_dir, scm, dvc):
tmp_dir.gen("params.json", '{"bar": 2, "foobar": 3}')
tmp_dir.gen("other_params.json", '{"foo": {"bar": 4}}')
dvc.run(
name="stage-0",
cmd="echo stage-0",
)
dvc.run(
name="stage-1",
cmd="echo stage-1",
@@ -83,6 +88,9 @@ def test_params_show_stages(params_repo):
assert api.params_show("params.json", stages="stage-3") == {"foobar": 3}
with pytest.raises(DvcException, match="No params found"):
api.params_show(stages="stage-0")
def test_params_show_revs(params_repo):
assert api.params_show(rev="HEAD~1") == {
@@ -145,3 +153,18 @@ def test_params_show_no_params_found(tmp_dir, dvc):
dvc.stage.add(name="echo", cmd="echo foo")
with pytest.raises(DvcException, match="No params found"):
api.params_show()
def test_params_show_stage_without_params(tmp_dir, dvc):
tmp_dir.gen("params.yaml", "foo: 1")
dvc.run(
name="stage-0",
cmd="echo stage-0",
)
with pytest.raises(DvcException, match="No params found"):
api.params_show(stages="stage-0")
with pytest.raises(DvcException, match="No params found"):
api.params_show(deps=True)