mirror of
https://github.com/Stone-Red-Code/dvc.git
synced 2026-11-02 07:18:25 +01:00
dvcfs: rename DvcFileSystem to DVCFileSystem (#8307)
This commit is contained in:
@@ -50,7 +50,7 @@ def test_open_dirty_hash(tmp_dir, dvc):
|
||||
|
||||
fs = DataFileSystem(index=dvc.index.data["repo"])
|
||||
with fs.open("file", "r") as fobj:
|
||||
# NOTE: Unlike DvcFileSystem, DataFileSystem should not
|
||||
# NOTE: Unlike DVCFileSystem, DataFileSystem should not
|
||||
# be affected by a dirty workspace.
|
||||
assert fobj.read() == "file"
|
||||
|
||||
@@ -71,7 +71,7 @@ def test_open_dirty_no_hash(tmp_dir, dvc):
|
||||
(tmp_dir / "file.dvc").write_text("outs:\n- path: file\n")
|
||||
|
||||
fs = DataFileSystem(index=dvc.index.data["repo"])
|
||||
# NOTE: Unlike DvcFileSystem, DataFileSystem should not
|
||||
# NOTE: Unlike DVCFileSystem, DataFileSystem should not
|
||||
# be affected by a dirty workspace.
|
||||
with pytest.raises(FileNotFoundError):
|
||||
with fs.open("file", "r"):
|
||||
|
||||
+30
-30
@@ -5,7 +5,7 @@ from unittest import mock
|
||||
|
||||
import pytest
|
||||
|
||||
from dvc.fs.dvc import DvcFileSystem
|
||||
from dvc.fs.dvc import DVCFileSystem
|
||||
from dvc.testing.tmp_dir import make_subrepo
|
||||
from dvc_data.hashfile.build import build
|
||||
from dvc_data.hashfile.hash_info import HashInfo
|
||||
@@ -16,7 +16,7 @@ def test_exists(tmp_dir, dvc):
|
||||
dvc.add("foo")
|
||||
(tmp_dir / "foo").unlink()
|
||||
|
||||
fs = DvcFileSystem(repo=dvc)
|
||||
fs = DVCFileSystem(repo=dvc)
|
||||
assert fs.exists("foo")
|
||||
|
||||
|
||||
@@ -25,7 +25,7 @@ def test_open(tmp_dir, dvc):
|
||||
dvc.add("foo")
|
||||
(tmp_dir / "foo").unlink()
|
||||
|
||||
fs = DvcFileSystem(repo=dvc)
|
||||
fs = DVCFileSystem(repo=dvc)
|
||||
with fs.open("foo", "r") as fobj:
|
||||
assert fobj.read() == "foo"
|
||||
|
||||
@@ -34,7 +34,7 @@ def test_open_dirty_hash(tmp_dir, dvc):
|
||||
tmp_dir.dvc_gen("file", "file")
|
||||
(tmp_dir / "file").write_text("something")
|
||||
|
||||
fs = DvcFileSystem(repo=dvc)
|
||||
fs = DVCFileSystem(repo=dvc)
|
||||
with fs.open("file", "r") as fobj:
|
||||
assert fobj.read() == "something"
|
||||
|
||||
@@ -43,7 +43,7 @@ def test_open_dirty_no_hash(tmp_dir, dvc):
|
||||
tmp_dir.gen("file", "file")
|
||||
(tmp_dir / "file.dvc").write_text("outs:\n- path: file\n")
|
||||
|
||||
fs = DvcFileSystem(repo=dvc)
|
||||
fs = DVCFileSystem(repo=dvc)
|
||||
with fs.open("file", "r") as fobj:
|
||||
assert fobj.read() == "file"
|
||||
|
||||
@@ -63,7 +63,7 @@ def test_open_in_history(tmp_dir, scm, dvc):
|
||||
if rev == "workspace":
|
||||
continue
|
||||
|
||||
fs = DvcFileSystem(repo=dvc)
|
||||
fs = DVCFileSystem(repo=dvc)
|
||||
with fs.open("foo", "r") as fobj:
|
||||
assert fobj.read() == "foo"
|
||||
|
||||
@@ -86,7 +86,7 @@ def test_isdir_isfile(tmp_dir, dvc):
|
||||
},
|
||||
)
|
||||
|
||||
fs = DvcFileSystem(repo=dvc)
|
||||
fs = DVCFileSystem(repo=dvc)
|
||||
assert fs.isdir("datadir")
|
||||
assert not fs.isfile("datadir")
|
||||
assert not fs.isdvc("datadir")
|
||||
@@ -107,7 +107,7 @@ def test_isdir_isfile(tmp_dir, dvc):
|
||||
(tmp_dir / "datafile").unlink()
|
||||
(tmp_dir / "subdir" / "baz").unlink()
|
||||
|
||||
fs = DvcFileSystem(repo=dvc)
|
||||
fs = DVCFileSystem(repo=dvc)
|
||||
assert fs.isdir("datadir")
|
||||
assert not fs.isfile("datadir")
|
||||
assert fs.isdvc("datadir")
|
||||
@@ -127,7 +127,7 @@ def test_exists_isdir_isfile_dirty(tmp_dir, dvc):
|
||||
{"datafile": "data", "datadir": {"foo": "foo", "bar": "bar"}}
|
||||
)
|
||||
|
||||
fs = DvcFileSystem(repo=dvc)
|
||||
fs = DVCFileSystem(repo=dvc)
|
||||
shutil.rmtree(tmp_dir / "datadir")
|
||||
(tmp_dir / "datafile").unlink()
|
||||
|
||||
@@ -162,7 +162,7 @@ def test_isdir_mixed(tmp_dir, dvc):
|
||||
|
||||
dvc.add(str(tmp_dir / "dir" / "foo"))
|
||||
|
||||
fs = DvcFileSystem(repo=dvc)
|
||||
fs = DVCFileSystem(repo=dvc)
|
||||
assert fs.isdir("dir")
|
||||
assert not fs.isfile("dir")
|
||||
|
||||
@@ -192,7 +192,7 @@ def test_walk(tmp_dir, dvc, dvcfiles, extra_expected):
|
||||
)
|
||||
dvc.add(str(tmp_dir / "dir"), recursive=True)
|
||||
tmp_dir.gen({"dir": {"foo": "foo", "bar": "bar"}})
|
||||
fs = DvcFileSystem(repo=dvc)
|
||||
fs = DVCFileSystem(repo=dvc)
|
||||
|
||||
expected = [
|
||||
"dir/subdir1",
|
||||
@@ -227,7 +227,7 @@ def test_walk_dirty(tmp_dir, dvc):
|
||||
tmp_dir.gen({"dir": {"bar": "bar", "subdir3": {"foo3": "foo3"}}})
|
||||
(tmp_dir / "dir" / "foo").unlink()
|
||||
|
||||
fs = DvcFileSystem(repo=dvc)
|
||||
fs = DVCFileSystem(repo=dvc)
|
||||
expected = [
|
||||
"dir/subdir1",
|
||||
"dir/subdir2",
|
||||
@@ -253,7 +253,7 @@ def test_walk_dirty_cached_dir(tmp_dir, scm, dvc):
|
||||
tmp_dir.dvc_gen({"data": {"foo": "foo", "bar": "bar"}}, commit="add data")
|
||||
(tmp_dir / "data" / "foo").unlink()
|
||||
|
||||
fs = DvcFileSystem(repo=dvc)
|
||||
fs = DVCFileSystem(repo=dvc)
|
||||
|
||||
actual = []
|
||||
for root, dirs, files in fs.walk("data"):
|
||||
@@ -277,7 +277,7 @@ def test_walk_mixed_dir(tmp_dir, scm, dvc):
|
||||
)
|
||||
tmp_dir.scm.commit("add dir")
|
||||
|
||||
fs = DvcFileSystem(repo=dvc)
|
||||
fs = DVCFileSystem(repo=dvc)
|
||||
|
||||
expected = [
|
||||
"dir/foo",
|
||||
@@ -294,7 +294,7 @@ def test_walk_mixed_dir(tmp_dir, scm, dvc):
|
||||
|
||||
|
||||
def test_walk_missing(tmp_dir, dvc):
|
||||
fs = DvcFileSystem(repo=dvc)
|
||||
fs = DVCFileSystem(repo=dvc)
|
||||
|
||||
for _ in fs.walk("dir"):
|
||||
pass
|
||||
@@ -302,7 +302,7 @@ def test_walk_missing(tmp_dir, dvc):
|
||||
|
||||
def test_walk_not_a_dir(tmp_dir, dvc):
|
||||
tmp_dir.dvc_gen("foo", "foo")
|
||||
fs = DvcFileSystem(repo=dvc)
|
||||
fs = DVCFileSystem(repo=dvc)
|
||||
|
||||
for _ in fs.walk("foo"):
|
||||
pass
|
||||
@@ -312,7 +312,7 @@ def test_isdvc(tmp_dir, dvc):
|
||||
tmp_dir.gen({"foo": "foo", "bar": "bar", "dir": {"baz": "baz"}})
|
||||
dvc.add("foo")
|
||||
dvc.add("dir")
|
||||
fs = DvcFileSystem(repo=dvc)
|
||||
fs = DVCFileSystem(repo=dvc)
|
||||
assert fs.isdvc("foo")
|
||||
assert not fs.isdvc("bar")
|
||||
assert fs.isdvc("dir")
|
||||
@@ -322,7 +322,7 @@ def test_isdvc(tmp_dir, dvc):
|
||||
|
||||
def test_subrepos(tmp_dir, scm, dvc, mocker):
|
||||
tmp_dir.scm_gen(
|
||||
{"dir": {"repo.txt": "file to confuse DvcFileSystem"}},
|
||||
{"dir": {"repo.txt": "file to confuse DVCFileSystem"}},
|
||||
commit="dir/repo.txt",
|
||||
)
|
||||
|
||||
@@ -340,7 +340,7 @@ def test_subrepos(tmp_dir, scm, dvc, mocker):
|
||||
)
|
||||
|
||||
dvc._reset()
|
||||
fs = DvcFileSystem(repo=dvc, subrepos=True)
|
||||
fs = DVCFileSystem(repo=dvc, subrepos=True)
|
||||
|
||||
def assert_fs_belongs_to_repo(ret_val):
|
||||
method = fs.fs._get_repo
|
||||
@@ -400,7 +400,7 @@ def test_subrepos(tmp_dir, scm, dvc, mocker):
|
||||
)
|
||||
def test_subrepo_walk(tmp_dir, scm, dvc, dvcfiles, extra_expected):
|
||||
tmp_dir.scm_gen(
|
||||
{"dir": {"repo.txt": "file to confuse DvcFileSystem"}},
|
||||
{"dir": {"repo.txt": "file to confuse DVCFileSystem"}},
|
||||
commit="dir/repo.txt",
|
||||
)
|
||||
|
||||
@@ -420,7 +420,7 @@ def test_subrepo_walk(tmp_dir, scm, dvc, dvcfiles, extra_expected):
|
||||
|
||||
# using fs that does not have dvcignore
|
||||
dvc._reset()
|
||||
fs = DvcFileSystem(repo=dvc)
|
||||
fs = DVCFileSystem(repo=dvc)
|
||||
expected = [
|
||||
"dir/repo",
|
||||
"dir/repo.txt",
|
||||
@@ -451,7 +451,7 @@ def test_subrepo_walk(tmp_dir, scm, dvc, dvcfiles, extra_expected):
|
||||
|
||||
def test_dvcfs_no_subrepos(tmp_dir, dvc, scm):
|
||||
tmp_dir.scm_gen(
|
||||
{"dir": {"repo.txt": "file to confuse DvcFileSystem"}},
|
||||
{"dir": {"repo.txt": "file to confuse DVCFileSystem"}},
|
||||
commit="dir/repo.txt",
|
||||
)
|
||||
tmp_dir.dvc_gen({"lorem": "lorem"}, commit="add foo")
|
||||
@@ -464,7 +464,7 @@ def test_dvcfs_no_subrepos(tmp_dir, dvc, scm):
|
||||
|
||||
# using fs that does not have dvcignore
|
||||
dvc._reset()
|
||||
fs = DvcFileSystem(repo=dvc)
|
||||
fs = DVCFileSystem(repo=dvc)
|
||||
expected = [
|
||||
"/.dvcignore",
|
||||
"/.gitignore",
|
||||
@@ -496,7 +496,7 @@ def test_dvcfs_no_subrepos(tmp_dir, dvc, scm):
|
||||
|
||||
def test_get_hash_cached_file(tmp_dir, dvc, mocker):
|
||||
tmp_dir.dvc_gen({"foo": "foo"})
|
||||
fs = DvcFileSystem(repo=dvc)
|
||||
fs = DVCFileSystem(repo=dvc)
|
||||
expected = "acbd18db4cc2f85cedef654fccc4a4d8"
|
||||
assert fs.info("foo").get("md5") is None
|
||||
_, _, obj = build(dvc.odb.local, "foo", fs, "md5")
|
||||
@@ -509,7 +509,7 @@ def test_get_hash_cached_dir(tmp_dir, dvc, mocker):
|
||||
tmp_dir.dvc_gen(
|
||||
{"dir": {"foo": "foo", "bar": "bar", "subdir": {"data": "data"}}}
|
||||
)
|
||||
fs = DvcFileSystem(repo=dvc)
|
||||
fs = DVCFileSystem(repo=dvc)
|
||||
expected = "8761c4e9acad696bee718615e23e22db.dir"
|
||||
assert fs.info("dir").get("md5") is None
|
||||
_, _, obj = build(dvc.odb.local, "dir", fs, "md5")
|
||||
@@ -529,7 +529,7 @@ def test_get_hash_cached_granular(tmp_dir, dvc, mocker):
|
||||
tmp_dir.dvc_gen(
|
||||
{"dir": {"foo": "foo", "bar": "bar", "subdir": {"data": "data"}}}
|
||||
)
|
||||
fs = DvcFileSystem(repo=dvc)
|
||||
fs = DVCFileSystem(repo=dvc)
|
||||
subdir = "dir/subdir"
|
||||
assert fs.info(subdir).get("md5") is None
|
||||
_, _, obj = build(dvc.odb.local, subdir, fs, "md5")
|
||||
@@ -558,7 +558,7 @@ def test_get_hash_mixed_dir(tmp_dir, scm, dvc):
|
||||
)
|
||||
tmp_dir.scm.commit("add dir")
|
||||
|
||||
fs = DvcFileSystem(repo=dvc)
|
||||
fs = DVCFileSystem(repo=dvc)
|
||||
_, _, obj = build(dvc.odb.local, "dir", fs, "md5")
|
||||
assert obj.hash_info == HashInfo(
|
||||
"md5", "e1d9e8eae5374860ae025ec84cfd85c7.dir"
|
||||
@@ -577,7 +577,7 @@ def test_get_hash_dirty_file(tmp_dir, dvc):
|
||||
|
||||
# file is modified in workspace
|
||||
# hash_file(file) should return workspace hash, not DVC cached hash
|
||||
fs = DvcFileSystem(repo=dvc)
|
||||
fs = DVCFileSystem(repo=dvc)
|
||||
assert fs.info("file").get("md5") is None
|
||||
staging, _, obj = build(dvc.odb.local, "file", fs, "md5")
|
||||
assert obj.hash_info == something_hash_info
|
||||
@@ -599,7 +599,7 @@ def test_get_hash_dirty_dir(tmp_dir, dvc):
|
||||
tmp_dir.dvc_gen({"dir": {"foo": "foo", "bar": "bar"}})
|
||||
(tmp_dir / "dir" / "baz").write_text("baz")
|
||||
|
||||
fs = DvcFileSystem(repo=dvc)
|
||||
fs = DVCFileSystem(repo=dvc)
|
||||
_, meta, obj = build(dvc.odb.local, "dir", fs, "md5")
|
||||
assert obj.hash_info == HashInfo(
|
||||
"md5", "ba75a2162ca9c29acecb7957105a0bc2.dir"
|
||||
@@ -661,7 +661,7 @@ def test_walk_nested_subrepos(tmp_dir, dvc, scm, traverse_subrepos):
|
||||
expected["/subrepo1"].add("subrepo3")
|
||||
|
||||
actual = {}
|
||||
fs = DvcFileSystem(repo=dvc)
|
||||
fs = DVCFileSystem(repo=dvc)
|
||||
for root, dirs, files in fs.walk(
|
||||
"/", ignore_subrepos=not traverse_subrepos
|
||||
):
|
||||
|
||||
@@ -2,7 +2,7 @@ import os
|
||||
|
||||
import pytest
|
||||
|
||||
from dvc.fs.dvc import DvcFileSystem
|
||||
from dvc.fs.dvc import DVCFileSystem
|
||||
from dvc.testing.tmp_dir import make_subrepo
|
||||
|
||||
|
||||
@@ -38,7 +38,7 @@ def dvcfs(tmp_dir, dvc, scm):
|
||||
tmp_dir.scm_gen(fs_structure, commit="repo init")
|
||||
tmp_dir.dvc_gen(dvc_structure, commit="use dvc")
|
||||
|
||||
yield DvcFileSystem(repo=dvc, subrepos=True)
|
||||
yield DVCFileSystem(repo=dvc, subrepos=True)
|
||||
|
||||
|
||||
def test_info_not_existing(dvcfs):
|
||||
|
||||
Reference in New Issue
Block a user