From 389fd48b5abf6dedea81b09966ae481d3596539a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Saugat=20Pachhai=20=28=E0=A4=B8=E0=A5=8C=E0=A4=97=E0=A4=BE?= =?UTF-8?q?=E0=A4=A4=29?= Date: Mon, 6 Dec 2021 20:22:29 +0545 Subject: [PATCH] exp init: change type to --type=live to --type=dl --- dvc/command/experiments.py | 2 +- dvc/repo/experiments/init.py | 2 +- tests/func/experiments/test_init.py | 8 ++++---- tests/unit/command/test_experiments.py | 6 +++--- 4 files changed, 9 insertions(+), 9 deletions(-) diff --git a/dvc/command/experiments.py b/dvc/command/experiments.py index d19c683d4..5aa63e158 100644 --- a/dvc/command/experiments.py +++ b/dvc/command/experiments.py @@ -1493,7 +1493,7 @@ def add_parser(subparsers, parent_parser): ) experiments_init_parser.add_argument( "--type", - choices=["default", "live"], + choices=["default", "dl"], default="default", help="Select type of stage to create (default: %(default)s)", ) diff --git a/dvc/repo/experiments/init.py b/dvc/repo/experiments/init.py index 7f9d73c9a..feefa01d0 100644 --- a/dvc/repo/experiments/init.py +++ b/dvc/repo/experiments/init.py @@ -220,7 +220,7 @@ def init( defaults = defaults.copy() if defaults else {} overrides = overrides.copy() if overrides else {} - with_live = type == "live" + with_live = type == "dl" if interactive: defaults = init_interactive( diff --git a/tests/func/experiments/test_init.py b/tests/func/experiments/test_init.py index 05bf99bab..4aabd049a 100644 --- a/tests/func/experiments/test_init.py +++ b/tests/func/experiments/test_init.py @@ -351,7 +351,7 @@ def test_init_interactive_live( init( dvc, - type="live", + type="dl", interactive=interactive, defaults=CmdExperimentsInit.DEFAULTS, overrides=overrides, @@ -359,7 +359,7 @@ def test_init_interactive_live( ) assert (tmp_dir / "dvc.yaml").parse() == { "stages": { - "live": { + "dl": { "cmd": "python script.py", "deps": ["data", "script.py"], "live": {"dvclive": {"html": True, "summary": True}}, @@ -395,7 +395,7 @@ def test_init_with_type_live_and_models_plots_provided( (tmp_dir / "params.yaml").dump({"foo": 1}) init( dvc, - type="live", + type="dl", interactive=interactive, stream=inp, defaults=CmdExperimentsInit.DEFAULTS, @@ -403,7 +403,7 @@ def test_init_with_type_live_and_models_plots_provided( ) assert (tmp_dir / "dvc.yaml").parse() == { "stages": { - "live": { + "dl": { "cmd": "cmd", "deps": ["data", "src"], "live": {"dvclive": {"html": True, "summary": True}}, diff --git a/tests/unit/command/test_experiments.py b/tests/unit/command/test_experiments.py index b7218f6f9..c256c2184 100644 --- a/tests/unit/command/test_experiments.py +++ b/tests/unit/command/test_experiments.py @@ -711,11 +711,11 @@ def test_experiments_init_cmd_not_required_for_interactive_mode(dvc, mocker): "extra_args, expected_kw", [ (["--type", "default"], {"type": "default"}), - (["--type", "live"], {"type": "live"}), + (["--type", "dl"], {"type": "dl"}), (["--force"], {"force": True}), ( - ["--name", "name", "--type", "live"], - {"name": "name", "type": "live"}, + ["--name", "name", "--type", "dl"], + {"name": "name", "type": "dl"}, ), ( [