From 324ff4be59923e1e0eb3ab715522264b8b31f2cb Mon Sep 17 00:00:00 2001
From: Ruslan Kuprieiev <kupruser@gmail.com>
Date: Wed, 20 May 2020 18:00:41 +0300
Subject: [PATCH] remote: is_dir_checksum: handle empty/None checksum (#3836)

Fixed #3434
---
 dvc/remote/base.py             | 2 ++
 tests/unit/remote/test_base.py | 8 ++++++++
 2 files changed, 10 insertions(+)

diff --git a/dvc/remote/base.py b/dvc/remote/base.py
index 039339100..ec6c6a0dc 100644
--- a/dvc/remote/base.py
+++ b/dvc/remote/base.py
@@ -319,6 +319,8 @@ class BaseRemote:
 
     @classmethod
     def is_dir_checksum(cls, checksum):
+        if not checksum:
+            return False
         return checksum.endswith(cls.CHECKSUM_DIR_SUFFIX)
 
     def get_checksum(self, path_info):
diff --git a/tests/unit/remote/test_base.py b/tests/unit/remote/test_base.py
index 1e07589df..c89b0474f 100644
--- a/tests/unit/remote/test_base.py
+++ b/tests/unit/remote/test_base.py
@@ -136,3 +136,11 @@ def test_cache_checksums(dvc):
     ):
         checksums = list(remote.cache_checksums())
         assert checksums == ["123456"]
+
+
+@pytest.mark.parametrize(
+    "checksum, result",
+    [(None, False), ("", False), ("3456.dir", True), ("3456", False)],
+)
+def test_is_dir_checksum(checksum, result):
+    assert BaseRemote.is_dir_checksum(checksum) == result