exp run: Use hydra for parsing --set-param.

- Overriding a config value : foo.bar=value
- Appending a config value : +foo.bar=value
- Appending or overriding a config value : ++foo.bar=value
- Removing a config value : ~foo.bar, ~foo.bar=value

See https://hydra.cc/docs/advanced/override_grammar/basic/#modifying-the-config-object

---

Breaking changes:

To modify a list, `foo[0]=bar` must now be passed as `foo.0=bar`.

Modifying a nested list inside a dictionary is not supported by omegaconf.

---

Closes #4883
Closes #5868
Closes #6129
This commit is contained in:
David de la Iglesia Castro
2022-08-05 17:53:24 +02:00
parent 45ac64ddde
commit 31635b8312
12 changed files with 339 additions and 210 deletions
+23 -1
View File
@@ -1,4 +1,6 @@
from dvc.utils.cli_parse import parse_params
import pytest
from dvc.utils.cli_parse import parse_params, to_path_overrides
def test_parse_params():
@@ -18,3 +20,23 @@ def test_parse_params():
{"file2": ["param2"]},
{"file3": []},
]
@pytest.mark.parametrize(
"params,expected",
[
(["foo=1"], {"params.yaml": ["foo=1"]}),
(["foo={bar: 1}"], {"params.yaml": ["foo={bar: 1}"]}),
(["foo.0=bar"], {"params.yaml": ["foo.0=bar"]}),
(["params.json:foo={bar: 1}"], {"params.json": ["foo={bar: 1}"]}),
(
["params.json:foo={bar: 1}", "baz=2", "goo=3"],
{
"params.json": ["foo={bar: 1}"],
"params.yaml": ["baz=2", "goo=3"],
},
),
],
)
def test_to_path_overrides(params, expected):
assert to_path_overrides(params) == expected