From d5abd797beb69b3879c137608495ec8f13ed2cca Mon Sep 17 00:00:00 2001 From: Ruslan Kuprieiev Date: Fri, 6 Apr 2018 02:09:21 +0300 Subject: [PATCH 1/3] dvc: fix logger Signed-off-by: Ruslan Kuprieiev --- dvc/cli.py | 5 ----- dvc/command/common/base.py | 8 ++++++++ 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/dvc/cli.py b/dvc/cli.py index 61953d265..cfbd99356 100644 --- a/dvc/cli.py +++ b/dvc/cli.py @@ -277,9 +277,4 @@ def parse_args(argv=None): args = parser.parse_args(argv) - if args.quiet and not args.verbose: - Logger.be_quiet() - elif not args.quiet and args.verbose: - Logger.be_verbose() - return args diff --git a/dvc/command/common/base.py b/dvc/command/common/base.py index b0ded05c1..d04d3763a 100644 --- a/dvc/command/common/base.py +++ b/dvc/command/common/base.py @@ -10,6 +10,14 @@ class CmdBase(object): def __init__(self, args): self.project = Project(self._find_root()) self.args = args + self._set_loglevel(args) + + @staticmethod + def _set_loglevel(args): + if args.quiet and not args.verbose: + Logger.be_quiet() + elif not args.quiet and args.verbose: + Logger.be_verbose() def _find_root(self): root = os.getcwd() From 5dbbe5713df0ef2224b5b1569f4ae702a24256ee Mon Sep 17 00:00:00 2001 From: Ruslan Kuprieiev Date: Fri, 6 Apr 2018 02:09:33 +0300 Subject: [PATCH 2/3] dvc: print msg about changed dependency Fixes #618 Signed-off-by: Ruslan Kuprieiev --- dvc/output.py | 21 ++++++++++++++------- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/dvc/output.py b/dvc/output.py index a4be21782..e81205aa5 100644 --- a/dvc/output.py +++ b/dvc/output.py @@ -77,8 +77,19 @@ class Dependency(object): return self.project.state.changed(self.path, self.md5) + @staticmethod + def _changed_msg(changed): + if changed: + return 'changed' + return "didn't change" + def changed(self): - return self._changed_md5() + ret = self._changed_md5() + + msg = u'Dependency \'{}\' {}'.format(self.rel_path, self._changed_msg(ret)) + self.project.logger.debug(msg) + + return ret def status(self): if self.changed(): @@ -231,12 +242,8 @@ class Output(Dependency): else: ret = self._changed_file(self.path, self.cache) - msg = u'Data file or dir \'{}\' with cache \'{}\' ' - if ret: - msg += 'changed' - else: - msg += 'didn\'t change' - self.project.logger.debug(msg.format(self.rel_path, self.rel_cache)) + msg = u'Data file or dir \'{}\' with cache \'{}\' {}' + self.project.logger.debug(msg.format(self.rel_path, self.rel_cache, self._changed_msg(ret))) return ret From 48e3ce03d6779e0a2072ab20f7987150c5244743 Mon Sep 17 00:00:00 2001 From: Ruslan Kuprieiev Date: Fri, 6 Apr 2018 02:11:48 +0300 Subject: [PATCH 3/3] dvc: run: fix dvcfile name generation Fixes #625 Signed-off-by: Ruslan Kuprieiev --- dvc/command/run.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/dvc/command/run.py b/dvc/command/run.py index 5c99296dd..b2fec20f6 100644 --- a/dvc/command/run.py +++ b/dvc/command/run.py @@ -42,5 +42,7 @@ class CmdRun(CmdBase): @staticmethod def _stage_file_basename(fname): result = os.path.basename(fname) + if len(result) == 0: + result = os.path.dirname(fname) result += Stage.STAGE_FILE_SUFFIX return result