From 215ea4944cc55359a90e93505236e711ed5c4cdb Mon Sep 17 00:00:00 2001 From: Saugat Pachhai Date: Mon, 8 Jun 2020 15:56:00 +0000 Subject: [PATCH] log: show modifying if entry already exists in dvcfile (#3978) --- dvc/dvcfile.py | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/dvc/dvcfile.py b/dvc/dvcfile.py index 1f9e25bbd..298fe1bdf 100644 --- a/dvc/dvcfile.py +++ b/dvc/dvcfile.py @@ -201,15 +201,17 @@ class PipelineFile(FileMixin): data["stages"] = data.get("stages", {}) stage_data = serialize.to_pipeline_file(stage) - if data["stages"].get(stage.name): + existing_entry = stage.name in data["stages"] + + action = "Modifying" if existing_entry else "Adding" + logger.info("%s stage '%s' in '%s'", action, stage.name, self.relpath) + + if existing_entry: orig_stage_data = data["stages"][stage.name] apply_diff(stage_data[stage.name], orig_stage_data) else: data["stages"].update(stage_data) - logger.info( - "Adding stage '%s' to '%s'", stage.name, self.relpath, - ) dump_yaml(self.path, data) self.repo.scm.track_file(self.relpath)