From 18177a657962f2e6f3b56c07e25b73ceca4450f9 Mon Sep 17 00:00:00 2001 From: skshetry <18718008+skshetry@users.noreply.github.com> Date: Thu, 5 Jun 2025 09:26:27 +0545 Subject: [PATCH] tests(bench): also check if dvc_rev is set (#10763) --- dvc/testing/benchmarks/cli/stories/use_cases/test_sharing.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dvc/testing/benchmarks/cli/stories/use_cases/test_sharing.py b/dvc/testing/benchmarks/cli/stories/use_cases/test_sharing.py index ba90724e4..e50f0c355 100644 --- a/dvc/testing/benchmarks/cli/stories/use_cases/test_sharing.py +++ b/dvc/testing/benchmarks/cli/stories/use_cases/test_sharing.py @@ -5,7 +5,7 @@ from packaging import version def test_sharing(bench_dvc, tmp_dir, dvc, make_dataset, remote, dvc_rev): is_gs = dvc.config["remote"]["upstream"]["url"].startswith("gs://") - if is_gs and version.Version(dvc_rev) < version.Version("3.59.3"): + if dvc_rev and is_gs and version.Version(dvc_rev) < version.Version("3.59.3"): # support for allow_anonymous_login in gs was introduced in dvc==3.59.3 with dvc.config.edit() as d: d["remote"]["upstream"].pop("allow_anonymous_login", None)