From 13a7e0f9780913ad5b79b9522e08e4f9bcdcc421 Mon Sep 17 00:00:00 2001 From: "Mr. Outis" Date: Tue, 15 Oct 2019 19:12:00 -0500 Subject: [PATCH] logger: send warning messages to stderr (#2612) * logger: send warning messages to stderr Fix #2561 * logger: filter warnings for stdout --- dvc/logger.py | 4 ++-- tests/unit/test_logger.py | 7 +++++++ 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/dvc/logger.py b/dvc/logger.py index 8e11f0e62..9fab58634 100644 --- a/dvc/logger.py +++ b/dvc/logger.py @@ -19,7 +19,7 @@ class LoggingException(Exception): class ExcludeErrorsFilter(logging.Filter): def filter(self, record): - return record.levelno < logging.ERROR + return record.levelno < logging.WARNING class ColorFormatter(logging.Formatter): @@ -182,7 +182,7 @@ def setup(level=logging.INFO): }, "console_errors": { "class": "dvc.logger.LoggerHandler", - "level": "ERROR", + "level": "WARNING", "formatter": "color", "stream": "ext://sys.stderr", }, diff --git a/tests/unit/test_logger.py b/tests/unit/test_logger.py index 57c876b3d..3560018a9 100644 --- a/tests/unit/test_logger.py +++ b/tests/unit/test_logger.py @@ -179,3 +179,10 @@ class TestColorFormatter: logger.info("some info") captured = capsys.readouterr() assert captured.out == "" + + +def test_handlers(): + stdout, stderr = logger.handlers + + assert stdout.level == logging.DEBUG + assert stderr.level == logging.WARNING