From 04e93da0bd492cc9e42a6c2f1fe837317bc079e7 Mon Sep 17 00:00:00 2001 From: Ruslan Kuprieiev Date: Thu, 23 Dec 2021 18:27:04 +0200 Subject: [PATCH] fs: remove unused RemoteCmdError --- dvc/fs/base.py | 8 -------- tests/unit/remote/test_base.py | 20 +------------------- 2 files changed, 1 insertion(+), 27 deletions(-) diff --git a/dvc/fs/base.py b/dvc/fs/base.py index af73de5ce..de695e6c2 100644 --- a/dvc/fs/base.py +++ b/dvc/fs/base.py @@ -18,14 +18,6 @@ from dvc.utils.fs import makedirs, move logger = logging.getLogger(__name__) -class RemoteCmdError(DvcException): - def __init__(self, remote, cmd, ret, err): - super().__init__( - "{remote} command '{cmd}' finished with non-zero return code" - " {ret}': {err}".format(remote=remote, cmd=cmd, ret=ret, err=err) - ) - - class RemoteActionNotImplemented(DvcException): def __init__(self, action, scheme): m = f"{action} is not supported for {scheme} remotes" diff --git a/tests/unit/remote/test_base.py b/tests/unit/remote/test_base.py index b61c5532a..4370b17e5 100644 --- a/tests/unit/remote/test_base.py +++ b/tests/unit/remote/test_base.py @@ -2,9 +2,7 @@ import math import posixpath from unittest import mock -import pytest - -from dvc.fs.base import FileSystem, RemoteCmdError +from dvc.fs.base import FileSystem from dvc.objects.db.base import ObjectDB @@ -18,22 +16,6 @@ class _CallableOrNone: CallableOrNone = _CallableOrNone() -def test_cmd_error(dvc): - config = {} - - cmd = "sed 'hello'" - ret = "1" - err = "sed: expression #1, char 2: extra characters after command" - - with mock.patch.object( - FileSystem, - "remove", - side_effect=RemoteCmdError("base", cmd, ret, err), - ): - with pytest.raises(RemoteCmdError): - FileSystem(**config).remove("file") - - @mock.patch.object(ObjectDB, "_list_hashes_traverse") @mock.patch.object(ObjectDB, "list_hashes_exists") def test_hashes_exist(object_exists, traverse, dvc):