Stone_Red/DesktopMagic
1
0
Fork 0
mirror of https://github.com/Stone-Red-Code/DesktopMagic.git synced 2026-09-06 23:39:09 +02:00
Code Issues Packages Projects Releases 10 Wiki Activity

Show error dialogs on UI thread using Dispatcher.InvokeAsync

Browse Source
This commit is contained in:
Stone_Red
2026-01-17 00:16:53 +01:00
parent dd9953cb7d
commit fca25aeb59
1 changed files with 45 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/DesktopMagic/Plugins/PluginWindow.xaml.cs
+45 -37
View File
@@ -202,13 +202,16 @@ public partial class PluginWindow : Window, IPluginWindow
if (pluginClassInstance is null && !File.Exists($"{PluginFolderPath}\\main.dll")) if (pluginClassInstance is null && !File.Exists($"{PluginFolderPath}\\main.dll"))
{ {
App.Logger.LogError($"\"{PluginMetadata.Name}\" - File \"main.dll\" does not exist", source: "Plugin"); App.Logger.LogError($"\"{PluginMetadata.Name}\" - File \"main.dll\" does not exist", source: "Plugin");
Wpf.Ui.Controls.MessageBox messageBox = new Wpf.Ui.Controls.MessageBox _ = await Dispatcher.InvokeAsync(async () =>
{ {
Title = $"Error \"{PluginMetadata.Name}\"", Wpf.Ui.Controls.MessageBox messageBox = new Wpf.Ui.Controls.MessageBox
Content = "File \"main.dll\" does not exist!", {
CloseButtonText = "Ok" Title = $"Error \"{PluginMetadata.Name}\"",
}; Content = "File \"main.dll\" does not exist!",
_ = await messageBox.ShowDialogAsync(); CloseButtonText = "Ok"
};
_ = await messageBox.ShowDialogAsync();
});
Exit(); Exit();
return; return;
@@ -277,13 +280,16 @@ public partial class PluginWindow : Window, IPluginWindow
if (instanceType is null) if (instanceType is null)
{ {
App.Logger.LogError($"\"{PluginMetadata.Name}\" - The \"Plugin\" class could not be found! It has to inherit from \"{typeof(Plugin).FullName}\"", source: "Plugin"); App.Logger.LogError($"\"{PluginMetadata.Name}\" - The \"Plugin\" class could not be found! It has to inherit from \"{typeof(Plugin).FullName}\"", source: "Plugin");
Wpf.Ui.Controls.MessageBox messageBox = new Wpf.Ui.Controls.MessageBox _ = await Dispatcher.InvokeAsync(async () =>
{ {
Title = $"Error \"{PluginMetadata.Name}\"", Wpf.Ui.Controls.MessageBox messageBox = new Wpf.Ui.Controls.MessageBox
Content = $"The \"Plugin\" class could not be found! It has to inherit from \"{typeof(Plugin).FullName}\"", {
CloseButtonText = "Ok" Title = $"Error \"{PluginMetadata.Name}\"",
}; Content = $"The \"Plugin\" class could not be found! It has to inherit from \"{typeof(Plugin).FullName}\"",
_ = await messageBox.ShowDialogAsync(); CloseButtonText = "Ok"
};
_ = await messageBox.ShowDialogAsync();
});
Exit(); Exit();
return; return;
} }
@@ -298,13 +304,16 @@ public partial class PluginWindow : Window, IPluginWindow
else else
{ {
App.Logger.LogError($"\"{PluginMetadata.Name}\" - The \"Plugin\" class could not be found! It has to inherit from \"{typeof(Plugin).FullName}\"", source: "Plugin"); App.Logger.LogError($"\"{PluginMetadata.Name}\" - The \"Plugin\" class could not be found! It has to inherit from \"{typeof(Plugin).FullName}\"", source: "Plugin");
Wpf.Ui.Controls.MessageBox messageBox = new Wpf.Ui.Controls.MessageBox _ = await Dispatcher.InvokeAsync(async () =>
{ {
Title = $"Error \"{PluginMetadata.Name}\"", Wpf.Ui.Controls.MessageBox messageBox = new Wpf.Ui.Controls.MessageBox
Content = $"The \"Plugin\" class has to inherit from \"{typeof(Plugin).FullName}\"", {
CloseButtonText = "Ok" Title = $"Error \"{PluginMetadata.Name}\"",
}; Content = $"The \"Plugin\" class has to inherit from \"{typeof(Plugin).FullName}\"",
_ = await messageBox.ShowDialogAsync(); CloseButtonText = "Ok"
};
_ = await messageBox.ShowDialogAsync();
});
Exit(); Exit();
return; return;
} }
@@ -413,10 +422,7 @@ public partial class PluginWindow : Window, IPluginWindow
try try
{ {
#pragma warning disable S3011 // Reflection should not be used to increase accessibility of classes, methods, or fields
FieldInfo[] props = instance.GetType().GetFields(BindingFlags.Instance | BindingFlags.NonPublic | BindingFlags.Public | BindingFlags.GetField); FieldInfo[] props = instance.GetType().GetFields(BindingFlags.Instance | BindingFlags.NonPublic | BindingFlags.Public | BindingFlags.GetField);
#pragma warning restore S3011 // Reflection should not be used to increase accessibility of classes, methods, or fields
List<SettingElement> settingElements = []; List<SettingElement> settingElements = [];
foreach (FieldInfo prop in props) foreach (FieldInfo prop in props)
{ {
@@ -458,13 +464,16 @@ public partial class PluginWindow : Window, IPluginWindow
{ {
IsRunning = false; IsRunning = false;
App.Logger.LogError($"\"{PluginMetadata.Name}\" - {ex}", source: "Plugin"); App.Logger.LogError($"\"{PluginMetadata.Name}\" - {ex}", source: "Plugin");
Wpf.Ui.Controls.MessageBox messageBox = new Wpf.Ui.Controls.MessageBox _ = await Dispatcher.InvokeAsync(async () =>
{ {
Title = $"Error \"{PluginMetadata.Name}\"", Wpf.Ui.Controls.MessageBox messageBox = new Wpf.Ui.Controls.MessageBox
Content = "File execution error:\n" + ex, {
CloseButtonText = "Ok" Title = $"Error \"{PluginMetadata.Name}\"",
}; Content = "File execution error:\n" + ex,
_ = await messageBox.ShowDialogAsync(); CloseButtonText = "Ok"
};
_ = await messageBox.ShowDialogAsync();
});
Exit(); Exit();
} }
} }
@@ -481,10 +490,8 @@ public partial class PluginWindow : Window, IPluginWindow
return; return;
} }
#pragma warning disable S3011 // Reflection should not be used to increase accessibility of classes, methods, or fields
FieldInfo[] fields = instance.GetType().GetFields(BindingFlags.Instance | BindingFlags.NonPublic | BindingFlags.Public); FieldInfo[] fields = instance.GetType().GetFields(BindingFlags.Instance | BindingFlags.NonPublic | BindingFlags.Public);
PropertyInfo[] properties = instance.GetType().GetProperties(BindingFlags.Instance | BindingFlags.NonPublic | BindingFlags.Public); PropertyInfo[] properties = instance.GetType().GetProperties(BindingFlags.Instance | BindingFlags.NonPublic | BindingFlags.Public);
#pragma warning restore S3011
// Load fields // Load fields
foreach (FieldInfo field in fields) foreach (FieldInfo field in fields)
@@ -546,10 +553,8 @@ public partial class PluginWindow : Window, IPluginWindow
try try
{ {
#pragma warning disable S3011 // Reflection should not be used to increase accessibility of classes, methods, or fields
FieldInfo[] fields = instance.GetType().GetFields(BindingFlags.Instance | BindingFlags.NonPublic | BindingFlags.Public); FieldInfo[] fields = instance.GetType().GetFields(BindingFlags.Instance | BindingFlags.NonPublic | BindingFlags.Public);
PropertyInfo[] properties = instance.GetType().GetProperties(BindingFlags.Instance | BindingFlags.NonPublic | BindingFlags.Public); PropertyInfo[] properties = instance.GetType().GetProperties(BindingFlags.Instance | BindingFlags.NonPublic | BindingFlags.Public);
#pragma warning restore S3011
// Save fields // Save fields
foreach (FieldInfo field in fields) foreach (FieldInfo field in fields)
@@ -655,13 +660,16 @@ public partial class PluginWindow : Window, IPluginWindow
{ {
IsRunning = false; IsRunning = false;
App.Logger.LogError($"\"{PluginMetadata.Name}\" - {ex}", source: "Plugin"); App.Logger.LogError($"\"{PluginMetadata.Name}\" - {ex}", source: "Plugin");
Wpf.Ui.Controls.MessageBox messageBox = new Wpf.Ui.Controls.MessageBox _ = await Dispatcher.InvokeAsync(async () =>
{ {
Title = $"Error \"{PluginMetadata.Name}\"", Wpf.Ui.Controls.MessageBox messageBox = new Wpf.Ui.Controls.MessageBox
Content = "File execution error:\n" + ex, {
CloseButtonText = "Ok" Title = $"Error \"{PluginMetadata.Name}\"",
}; Content = "File execution error:\n" + ex,
_ = await messageBox.ShowDialogAsync(); CloseButtonText = "Ok"
};
_ = await messageBox.ShowDialogAsync();
});
Exit(); Exit();
return; return;
} }