Stefan-5422/-T5-Elektrifikatsiya
1
0
Fork 0
mirror of https://github.com/Stefan-5422/-T5-Elektrifikatsiya.git synced 2026-09-04 00:45:58 +02:00
Code Issues 2 Packages Projects Releases Wiki Activity

Improve error handling in DeviceManagmentService

Browse Source
This commit is contained in:
Stone_Red
2023-03-07 18:10:22 +01:00
parent 2f906063e9
commit 814c0d9ca4
1 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Elektrifikatsiya/Elektrifikatsiya/Services/Implementations/DeviceManagmentService.cs
+8 -4
View File
@@ -10,7 +10,6 @@ namespace Elektrifikatsiya.Services.Implementations;
public class DeviceManagmentService : IDeviceManagmentService public class DeviceManagmentService : IDeviceManagmentService
{ {
private readonly DeviceManagmentDatabaseContext deviceManagmentDatabaseContext;
private readonly IServiceScopeFactory serviceScopeFactory; private readonly IServiceScopeFactory serviceScopeFactory;
private readonly IDeviceStatusService deviceStatusService; private readonly IDeviceStatusService deviceStatusService;
private readonly ILogger<DeviceManagmentService> logger; private readonly ILogger<DeviceManagmentService> logger;
@@ -22,7 +21,6 @@ public class DeviceManagmentService : IDeviceManagmentService
this.deviceStatusService = deviceStatusService; this.deviceStatusService = deviceStatusService;
this.logger = logger; this.logger = logger;
this.httpClient = httpClient; this.httpClient = httpClient;
} }
public Result<Device> GetDevice(string macAdress) public Result<Device> GetDevice(string macAdress)
@@ -113,9 +111,12 @@ public class DeviceManagmentService : IDeviceManagmentService
_ = deviceManagmentDatabaseContext.Add(device); _ = deviceManagmentDatabaseContext.Add(device);
Result saveDatabaseChangesResult = await Result.Try(Task () => deviceManagmentDatabaseContext.SaveChangesAsync()); Result saveDatabaseChangesResult = await Result.Try(Task () => deviceManagmentDatabaseContext.SaveChangesAsync());
Result trackDeviceResult = deviceStatusService.TrackDevice(device); if (saveDatabaseChangesResult.IsFailed)
{
return saveDatabaseChangesResult;
}
return Result.Merge(saveDatabaseChangesResult, trackDeviceResult).ToResult(device); return deviceStatusService.TrackDevice(device);
} }
public async Task<Result> UnregisterDevice(string macAdress) public async Task<Result> UnregisterDevice(string macAdress)
@@ -144,6 +145,9 @@ public class DeviceManagmentService : IDeviceManagmentService
public async Task<Result> UpdateDevice(Device device) public async Task<Result> UpdateDevice(Device device)
{ {
using IServiceScope scope = serviceScopeFactory.CreateScope();
DeviceManagmentDatabaseContext deviceManagmentDatabaseContext = scope.ServiceProvider.GetRequiredService<DeviceManagmentDatabaseContext>();
Result result = deviceStatusService.UpdateDeviceStatus(device); Result result = deviceStatusService.UpdateDeviceStatus(device);
if (result.IsFailed) if (result.IsFailed)