[PR #83] fix: save refreshed tokens for server URLs with a trailing slash #84

Open
opened 2026-11-03 23:01:22 +01:00 by Stone_Red · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/RedWizardsLab/EchoHub/pull/83
Author: @Stone-Red-Code
Created: 11/3/2026
Status: 🔄 Open

Base: dev ← Head: dev_fix_refresh_token_saving


📝 Commits (2)

  • 506dd92 fix: save refreshed tokens for server URLs with a trailing slash
  • 89dba31 chore: add changelog

📊 Changes

6 files changed (+46 additions, -9 deletions)

View changed files

📝 docs/changelog/index.md (+1 -1)
📝 docs/changelog/v0.2.18.md (+4 -0)
📝 src/EchoHub.Client/AppOrchestrator.cs (+1 -2)
📝 src/EchoHub.Client/Config/ClientConfig.cs (+8 -0)
📝 src/EchoHub.Client/Services/ConnectionManager.cs (+2 -6)
➕ src/EchoHub.Tests/ClientConfigTests.cs (+30 -0)

📄 Description

Summary

Fixes issue where ConnectionManager.cs failed to save rotated refresh tokens for servers whose saved URL ends in a trailing slash, because it looked them up using ApiClient.BaseUrl, which trimmed trailing slashes.

All server lookups in ConnectionManager and AppOrchestrator.UpdateServerConfig now use the ClientConfig.FindServer method that ignores trailing slashes and letter case, so refreshed tokens and other settings are saved correctly.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/RedWizardsLab/EchoHub/pull/83 **Author:** [@Stone-Red-Code](https://github.com/Stone-Red-Code) **Created:** 11/3/2026 **Status:** 🔄 Open **Base:** `dev` ← **Head:** `dev_fix_refresh_token_saving` --- ### 📝 Commits (2) - [`506dd92`](https://github.com/RedWizardsLab/EchoHub/commit/506dd9241f910e0ef68c61bdf0e66f38398b1661) fix: save refreshed tokens for server URLs with a trailing slash - [`89dba31`](https://github.com/RedWizardsLab/EchoHub/commit/89dba31185bd44451378f2dd56e3ae5608d58a99) chore: add changelog ### 📊 Changes **6 files changed** (+46 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `docs/changelog/index.md` (+1 -1) 📝 `docs/changelog/v0.2.18.md` (+4 -0) 📝 `src/EchoHub.Client/AppOrchestrator.cs` (+1 -2) 📝 `src/EchoHub.Client/Config/ClientConfig.cs` (+8 -0) 📝 `src/EchoHub.Client/Services/ConnectionManager.cs` (+2 -6) ➕ `src/EchoHub.Tests/ClientConfigTests.cs` (+30 -0) </details> ### 📄 Description # Summary Fixes issue where `ConnectionManager.cs` failed to save rotated refresh tokens for servers whose saved URL ends in a trailing slash, because it looked them up using `ApiClient.BaseUrl`, which trimmed trailing slashes. All server lookups in ConnectionManager and `AppOrchestrator.UpdateServerConfig` now use the `ClientConfig.FindServer` method that ignores trailing slashes and letter case, so refreshed tokens and other settings are saved correctly. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Stone_Red added the pull-request label 2026-11-03 23:01:22 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: RedWizardsLab/EchoHub#84