RedWizardsLab/EchoHub
1
0
Fork 0
mirror of https://github.com/RedWizardsLab/EchoHub.git synced 2026-09-04 00:26:07 +02:00
Code Issues 2 Packages Projects Releases 10 Wiki Activity

[PR #28] [MERGED] fix: ghost channel when trying to join a channel that doesn't exist #30

New Issue
Closed
opened 2026-09-04 00:49:46 +02:00 by Stone_Red · 0 comments
Stone_Red commented 2026-09-04 00:49:46 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/RedWizardsLab/EchoHub/pull/28
Author: @Stone-Red-Code
Created: 2/24/2026
Status: ✅ Merged
Merged: 2/24/2026
Merged by: @Stone-Red-Code

Base: dev ← Head: dev_fix_ghost_channel_on_join

📝 Commits (5)

  • 24a5bdb fix: ghost channel when trying to join a channel that doesn't exist
  • b0adb55 refactor: Move JoinChannelResult to the correct position in ChatDtos.cs
  • 29bfd87 fix: ghost channel when trying to join a channel that doesn't exist
  • 3896640 refactor: Move JoinChannelResult to the correct position in ChatDtos.cs
  • d4f5402 chore: add ghost channel fixes to changelog

📊 Changes

4 files changed (+12 additions, -10 deletions)

View changed files

📝 docs/changelog/v0.2.8.md (+2 -0)
📝 src/EchoHub.Client/Services/EchoHubConnection.cs (+4 -2)
📝 src/EchoHub.Core/DTOs/ChatDtos.cs (+2 -0)
📝 src/EchoHub.Server/Hubs/ChatHub.cs (+4 -8)

📄 Description

Summary

Fix client creating ghost channel when trying to join a channel that doesn't exist

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/RedWizardsLab/EchoHub/pull/28 **Author:** [@Stone-Red-Code](https://github.com/Stone-Red-Code) **Created:** 2/24/2026 **Status:** ✅ Merged **Merged:** 2/24/2026 **Merged by:** [@Stone-Red-Code](https://github.com/Stone-Red-Code) **Base:** `dev` ← **Head:** `dev_fix_ghost_channel_on_join` --- ### 📝 Commits (5) - [`24a5bdb`](https://github.com/RedWizardsLab/EchoHub/commit/24a5bdb9a1cfb51d7b42a72866c3fbbac8e2e75a) fix: ghost channel when trying to join a channel that doesn't exist - [`b0adb55`](https://github.com/RedWizardsLab/EchoHub/commit/b0adb55b8f032c51979ab7ba231f8cb610f9acaf) refactor: Move JoinChannelResult to the correct position in ChatDtos.cs - [`29bfd87`](https://github.com/RedWizardsLab/EchoHub/commit/29bfd87d8b41dbdd43d45e8e4d0a338489a5074d) fix: ghost channel when trying to join a channel that doesn't exist - [`3896640`](https://github.com/RedWizardsLab/EchoHub/commit/3896640ac76bb110396ab8b757f006eef9e5a8e6) refactor: Move JoinChannelResult to the correct position in ChatDtos.cs - [`d4f5402`](https://github.com/RedWizardsLab/EchoHub/commit/d4f540285b7936470382856fdb1808983eec134c) chore: add ghost channel fixes to changelog ### 📊 Changes **4 files changed** (+12 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `docs/changelog/v0.2.8.md` (+2 -0) 📝 `src/EchoHub.Client/Services/EchoHubConnection.cs` (+4 -2) 📝 `src/EchoHub.Core/DTOs/ChatDtos.cs` (+2 -0) 📝 `src/EchoHub.Server/Hubs/ChatHub.cs` (+4 -8) </details> ### 📄 Description # Summary Fix client creating ghost channel when trying to join a channel that doesn't exist --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Stone_Red added the pull-request label 2026-09-04 00:49:46 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
good first issue
good first issue
pull-request
Mirrored from GitHub Pull Request
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
Stone_Red
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: RedWizardsLab/EchoHub#30