RedWizardsLab/EchoHub
1
0
Fork 0
mirror of https://github.com/RedWizardsLab/EchoHub.git synced 2026-09-04 16:46:08 +02:00
Code Issues 2 Packages Projects Releases 10 Wiki Activity

feat: enhance SASL authentication logging for better traceability

Browse Source
This commit is contained in:
HueByte
2026-02-23 10:40:56 +01:00
parent 45fd382b13
commit c2a8e9cfc8
1 changed files with 14 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/EchoHub.Server.Irc/IrcCommandHandler.cs
+14 -1
View File
@@ -154,10 +154,15 @@ public sealed class IrcCommandHandler
var username = (parts[1].Length > 0 ? parts[1] : parts[0]).ToLowerInvariant(); var username = (parts[1].Length > 0 ? parts[1] : parts[0]).ToLowerInvariant();
var password = parts[2]; var password = parts[2];
_logger.LogDebug("SASL PLAIN auth attempt for user '{Username}' (connection {Id})",
username, _conn.ConnectionId);
var result = await _chatService.AuthenticateUserAsync(username, password); var result = await _chatService.AuthenticateUserAsync(username, password);
if (result is null) if (result is null)
{ {
_logger.LogWarning("SASL auth failed for user '{Username}' (connection {Id})",
username, _conn.ConnectionId);
await _conn.SendNumericAsync(ServerName, IrcNumericReply.ERR_SASLFAIL, await _conn.SendNumericAsync(ServerName, IrcNumericReply.ERR_SASLFAIL,
":SASL authentication failed"); ":SASL authentication failed");
return; return;
@@ -167,13 +172,17 @@ public sealed class IrcCommandHandler
_conn.UserId = result.Value.UserId; _conn.UserId = result.Value.UserId;
_conn.IsAuthenticated = true; _conn.IsAuthenticated = true;
_logger.LogInformation("SASL auth succeeded for user '{Username}' (connection {Id})",
username, _conn.ConnectionId);
await _conn.SendNumericAsync(ServerName, IrcNumericReply.RPL_LOGGEDIN, await _conn.SendNumericAsync(ServerName, IrcNumericReply.RPL_LOGGEDIN,
$"{_conn.Hostmask} {username} :You are now logged in as {username}"); $"{_conn.Hostmask} {username} :You are now logged in as {username}");
await _conn.SendNumericAsync(ServerName, IrcNumericReply.RPL_SASLSUCCESS, await _conn.SendNumericAsync(ServerName, IrcNumericReply.RPL_SASLSUCCESS,
":SASL authentication successful"); ":SASL authentication successful");
} }
catch catch (Exception ex)
{ {
_logger.LogError(ex, "SASL auth exception for connection {Id}", _conn.ConnectionId);
await _conn.SendNumericAsync(ServerName, IrcNumericReply.ERR_SASLFAIL, await _conn.SendNumericAsync(ServerName, IrcNumericReply.ERR_SASLFAIL,
":SASL authentication failed"); ":SASL authentication failed");
} }
@@ -240,6 +249,10 @@ public sealed class IrcCommandHandler
private async Task TryCompleteRegistrationAsync() private async Task TryCompleteRegistrationAsync()
{ {
_logger.LogDebug("TryCompleteRegistration: CapNeg={Cap}, Registered={Reg}, Authenticated={Auth}, Nick={Nick}, User={User}, Id={Id}",
_conn.CapNegotiating, _conn.IsRegistered, _conn.IsAuthenticated,
_conn.Nickname, _conn.Username, _conn.ConnectionId);
if (_conn.CapNegotiating || _conn.IsRegistered) return; if (_conn.CapNegotiating || _conn.IsRegistered) return;
// SASL already authenticated // SASL already authenticated