fix: update release workflow to use --notes-file for release notes to prevent shell expansion issues

This commit is contained in:
HueByte
2026-02-22 06:03:08 +01:00
parent 17e64293b5
commit 03f4685ae6
2 changed files with 3 additions and 5 deletions
+2 -5
View File
@@ -107,7 +107,6 @@ jobs:
- name: Build release notes - name: Build release notes
if: steps.changes.outputs.src_changed == 'true' && steps.check_release.outputs.exists == 'false' if: steps.changes.outputs.src_changed == 'true' && steps.check_release.outputs.exists == 'false'
id: notes
run: | run: |
TAG="${{ steps.version.outputs.tag }}" TAG="${{ steps.version.outputs.tag }}"
CHANGELOG_URL="https://huebyte.github.io/EchoHub/changelog/${TAG}.html" CHANGELOG_URL="https://huebyte.github.io/EchoHub/changelog/${TAG}.html"
@@ -115,7 +114,6 @@ jobs:
PREV_TAG=$(git tag --sort=-v:refname | grep -v "^${TAG}$" | head -n 1) PREV_TAG=$(git tag --sort=-v:refname | grep -v "^${TAG}$" | head -n 1)
{ {
echo "body<<RELEASE_EOF"
echo "📋 **[Full Changelog](${CHANGELOG_URL})**" echo "📋 **[Full Changelog](${CHANGELOG_URL})**"
echo "" echo ""
echo "---" echo "---"
@@ -134,15 +132,14 @@ jobs:
else else
echo "*Version diff: [${TAG}](${REPO}/commits/${TAG})*" echo "*Version diff: [${TAG}](${REPO}/commits/${TAG})*"
fi fi
echo "RELEASE_EOF" } > release-notes.md
} >> "$GITHUB_OUTPUT"
- name: Create GitHub Release - name: Create GitHub Release
if: steps.changes.outputs.src_changed == 'true' && steps.check_release.outputs.exists == 'false' if: steps.changes.outputs.src_changed == 'true' && steps.check_release.outputs.exists == 'false'
run: | run: |
gh release create "${{ steps.version.outputs.tag }}" \ gh release create "${{ steps.version.outputs.tag }}" \
--title "EchoHub ${{ steps.version.outputs.tag }}" \ --title "EchoHub ${{ steps.version.outputs.tag }}" \
--notes "${{ steps.notes.outputs.body }}" \ --notes-file release-notes.md \
EchoHub-Server-win-x64.zip \ EchoHub-Server-win-x64.zip \
EchoHub-Server-linux-x64.zip \ EchoHub-Server-linux-x64.zip \
EchoHub-Server-osx-x64.zip \ EchoHub-Server-osx-x64.zip \
+1
View File
@@ -110,6 +110,7 @@
- Root `nuget.config` added for package source management - Root `nuget.config` added for package source management
- Terminal.Gui formatting excluded from CI format checks - Terminal.Gui formatting excluded from CI format checks
- Recursive submodule fetching enabled in CI workflows - Recursive submodule fetching enabled in CI workflows
- Release workflow: use `--notes-file` instead of inline `--notes` interpolation to prevent shell expansion of special characters in commit messages
- `Server:Admins` config array in `appsettings.example.json` for designating admin usernames - `Server:Admins` config array in `appsettings.example.json` for designating admin usernames
- `Storage:CleanupIntervalHours` and `Storage:RetentionDays` added to `appsettings.example.json` - `Storage:CleanupIntervalHours` and `Storage:RetentionDays` added to `appsettings.example.json`
- `FakeChannelService` test helper added for IRC unit tests - `FakeChannelService` test helper added for IRC unit tests